C++: Replace toString logic.

geoffw0 · geoffw0 · commit 725122decc62 · 2021-03-26T17:29:05.000Z
diff --git a/cpp/ql/src/experimental/Security/CWE/CWE-570/WrongInDetectingAndHandlingMemoryAllocationErrors.ql b/cpp/ql/src/experimental/Security/CWE/CWE-570/WrongInDetectingAndHandlingMemoryAllocationErrors.ql
@@ -74,7 +74,7 @@ class WrongCheckErrorOperatorNew extends FunctionCall {
   /**
    * Holds if `(std::nothrow)` exists in call `operator new`.
    */
-  predicate isExistsNothrow() { this.getAChild().toString() = "nothrow" }
+  predicate isExistsNothrow() { getTarget().isNoExcept() or getTarget().isNoThrow() }
 }
 
 from WrongCheckErrorOperatorNew op

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ class WrongCheckErrorOperatorNew extends FunctionCall {`
`74`	`74`	`/**`
`75`	`75`	* Holds if `(std::nothrow)` exists in call `operator new`.
`76`	`76`	`*/`
`77`		`- predicate isExistsNothrow() { this.getAChild().toString() = "nothrow" }`
	`77`	`+ predicate isExistsNothrow() { getTarget().isNoExcept() or getTarget().isNoThrow() }`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`from WrongCheckErrorOperatorNew op`