Merge pull request github#3574 from hvitved/csharp/unification-performance

calumgrant · web-flow · commit 725a8f55ca9c · 2020-05-28T10:39:02.000+01:00
C#: Fix performance issue in unification library
diff --git a/csharp/ql/src/semmle/code/csharp/Unification.qll b/csharp/ql/src/semmle/code/csharp/Unification.qll
@@ -474,7 +474,8 @@ module Gvn {
         sourceDecl = any(GenericType t).getSourceDeclaration() and
         not sourceDecl instanceof PointerType and
         not sourceDecl instanceof NullableType and
-        not sourceDecl instanceof ArrayType
+        not sourceDecl instanceof ArrayType and
+        not sourceDecl instanceof TupleType
       }
 
     cached

Original file line number	Diff line number	Diff line change
`@@ -474,7 +474,8 @@ module Gvn {`
`474`	`474`	`sourceDecl = any(GenericType t).getSourceDeclaration() and`
`475`	`475`	`not sourceDecl instanceof PointerType and`
`476`	`476`	`not sourceDecl instanceof NullableType and`
`477`		`- not sourceDecl instanceof ArrayType`
	`477`	`+ not sourceDecl instanceof ArrayType and`
	`478`	`+ not sourceDecl instanceof TupleType`
`478`	`479`	`}`
`479`	`480`
`480`	`481`	`cached`