Java: Add back StringInputStream to CloseReader.ql

Marcono1234 · Marcono1234 · commit 73c7e15580bc · 2021-05-14T22:25:00.000+02:00
diff --git a/java/ql/src/Likely Bugs/Resource Leaks/CloseReader.ql b/java/ql/src/Likely Bugs/Resource Leaks/CloseReader.ql
@@ -25,6 +25,9 @@ predicate readerType(RefType t) {
 predicate safeReaderType(RefType t) {
   exists(RefType sup | sup = t.getASupertype*() |
     sup.hasQualifiedName("java.io", ["CharArrayReader", "StringReader", "ByteArrayInputStream"])
+    or
+    // Note: It is unclear which specific class this is supposed to match
+    sup.hasName("StringInputStream")
   )
 }
 

Original file line number	Diff line number	Diff line change
`@@ -25,6 +25,9 @@ predicate readerType(RefType t) {`
`25`	`25`	`predicate safeReaderType(RefType t) {`
`26`	`26`	`exists(RefType sup \| sup = t.getASupertype*() \|`
`27`	`27`	`sup.hasQualifiedName("java.io", ["CharArrayReader", "StringReader", "ByteArrayInputStream"])`
	`28`	`+ or`
	`29`	`+ // Note: It is unclear which specific class this is supposed to match`
	`30`	`+ sup.hasName("StringInputStream")`
`28`	`31`	`)`
`29`	`32`	`}`
`30`	`33`