Skip to content

Commit 752620a

Browse files
committed
Rename SSL configuration and fix PathGraph
1 parent efdfc2d commit 752620a

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

java/ql/lib/semmle/code/java/security/InsecureLdapAuthQuery.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ module BasicAuthFlowConfiguration = DataFlow::Make<BasicAuthFlowConfig>;
5454
/**
5555
* A taint-tracking configuration for `ssl` configuration in LDAP authentication.
5656
*/
57-
private module SslFlowConfig implements DataFlow::ConfigSig {
57+
private module RequiresSslConfig implements DataFlow::ConfigSig {
5858
predicate isSource(DataFlow::Node src) {
5959
exists(MethodAccess ma |
6060
isSslEnv(ma) and ma.getQualifier() = src.(PostUpdateNode).getPreUpdateNode().asExpr()
@@ -69,4 +69,4 @@ private module SslFlowConfig implements DataFlow::ConfigSig {
6969
}
7070
}
7171

72-
module SslFlowConfiguration = DataFlow::Make<SslFlowConfig>;
72+
module RequiresSslConfiguration = DataFlow::Make<RequiresSslConfig>;

java/ql/src/Security/CWE/CWE-522/InsecureLdapAuth.ql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@
1414

1515
import java
1616
import semmle.code.java.security.InsecureLdapAuthQuery
17-
import InsecureLdapAuthQuery::PathGraph
17+
import InsecureUrlFlowConfiguration::PathGraph
1818

1919
from InsecureUrlFlowConfiguration::PathNode source, InsecureUrlFlowConfiguration::PathNode sink
2020
where
2121
InsecureUrlFlowConfiguration::hasFlowPath(source, sink) and
2222
BasicAuthFlowConfiguration::hasFlowTo(sink.getNode()) and
23-
not SslFlowConfiguration::hasFlowTo(sink.getNode())
23+
not RequiresSslConfiguration::hasFlowTo(sink.getNode())
2424
select sink.getNode(), source, sink, "Insecure LDAP authentication from $@.", source.getNode(),
2525
"LDAP connection string"

0 commit comments

Comments
 (0)