Skip to content

Commit 7959e76

Browse files
Better qldoc in UnsafeDeserializationQuery.qll
Co-authored-by: Anders Schack-Mulligen <[email protected]>
1 parent a4b0041 commit 7959e76

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

java/ql/src/semmle/code/java/security/UnsafeDeserializationQuery.qll

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
/**
2-
* Provides classes and predicates for deserialization vulnerabilities.
2+
* Provides classes and predicates for finding deserialization vulnerabilities.
33
*/
44

55
import semmle.code.java.dataflow.FlowSources
@@ -123,7 +123,7 @@ private class SafeKryo extends DataFlow2::Configuration {
123123
}
124124

125125
/**
126-
* Holds if `ma` is a call that triggers deserialization with tainted data from `sink`.
126+
* Holds if `ma` is a call that deserializes data from `sink`.
127127
*/
128128
predicate unsafeDeserialization(MethodAccess ma, Expr sink) {
129129
exists(Method m | m = ma.getMethod() |
@@ -191,7 +191,7 @@ predicate unsafeDeserialization(MethodAccess ma, Expr sink) {
191191
class UnsafeDeserializationSink extends DataFlow::ExprNode {
192192
UnsafeDeserializationSink() { unsafeDeserialization(_, this.getExpr()) }
193193

194-
/** Returns a call that triggers unsafe deserialization. */
194+
/** Gets a call that triggers unsafe deserialization. */
195195
MethodAccess getMethodAccess() { unsafeDeserialization(result, this.getExpr()) }
196196
}
197197

@@ -286,7 +286,7 @@ class EnableJacksonDefaultTypingConfig extends DataFlow2::Configuration {
286286
}
287287

288288
/**
289-
* Tracks flow from calls which set a type validator to a subsequent Jackson deserialization method call,
289+
* Tracks flow from calls that set a type validator to a subsequent Jackson deserialization method call,
290290
* including across builder method calls.
291291
*
292292
* Such a Jackson deserialization method call is safe because validation will likely prevent instantiating unexpected types.

0 commit comments

Comments
 (0)