Swift: Specialize the additional taint step a bit more.

geoffw0 · geoffw0 · commit 7feab09ea953 · 2023-03-16T08:57:31.000Z
diff --git a/swift/ql/lib/codeql/swift/security/CleartextStorageDatabaseExtensions.qll b/swift/ql/lib/codeql/swift/security/CleartextStorageDatabaseExtensions.qll
@@ -137,7 +137,7 @@ private class CleartextStorageDatabaseArrayAdditionalTaintStep extends Cleartext
     //  approximate; for example we might identify `passwordBox` as a source,
     //  whereas it is more accurate to say that `passwordBox.textField` is the
     //  true source).
-    nodeTo.asExpr().(LookupExpr).getBase() = nodeFrom.asExpr()
+    nodeTo.asExpr().(MemberRefExpr).getBase() = nodeFrom.asExpr()
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -137,7 +137,7 @@ private class CleartextStorageDatabaseArrayAdditionalTaintStep extends Cleartext`
`137`	`137`	// approximate; for example we might identify `passwordBox` as a source,
`138`	`138`	// whereas it is more accurate to say that `passwordBox.textField` is the
`139`	`139`	`// true source).`
`140`		`- nodeTo.asExpr().(LookupExpr).getBase() = nodeFrom.asExpr()`
	`140`	`+ nodeTo.asExpr().(MemberRefExpr).getBase() = nodeFrom.asExpr()`
`141`	`141`	`}`
`142`	`142`	`}`
`143`	`143`