Merge pull request github#6577 from tamasvajk/fix/cil-modified-pointer

tamasvajk · web-flow · commit 82f61ca01589 · 2021-09-02T10:48:51.000+02:00
C#: Temporarily extract modified pointers as unmodified during CIL ex…
diff --git a/csharp/extractor/Semmle.Extraction.CIL/Entities/PointerType.cs b/csharp/extractor/Semmle.Extraction.CIL/Entities/PointerType.cs
@@ -11,6 +11,14 @@ internal sealed class PointerType : Type
         public PointerType(Context cx, Type pointee) : base(cx)
         {
             this.pointee = pointee;
+
+            if (pointee is ModifiedType mt)
+            {
+                cx.Extractor.Logger.Log(
+                    Util.Logging.Severity.Info,
+                    $"Pointer to modified type {pointee.GetQualifiedName()} is changed to {mt.Unmodified.GetQualifiedName()}");
+                this.pointee = mt.Unmodified;
+            }
         }
 
         public override bool Equals(object? obj)

Original file line number	Diff line number	Diff line change
`@@ -11,6 +11,14 @@ internal sealed class PointerType : Type`
`11`	`11`	`public PointerType(Context cx, Type pointee) : base(cx)`
`12`	`12`	`{`
`13`	`13`	`this.pointee = pointee;`
	`14`	`+`
	`15`	`+ if (pointee is ModifiedType mt)`
	`16`	`+ {`
	`17`	`+ cx.Extractor.Logger.Log(`
	`18`	`+ Util.Logging.Severity.Info,`
	`19`	`+ $"Pointer to modified type {pointee.GetQualifiedName()} is changed to {mt.Unmodified.GetQualifiedName()}");`
	`20`	`+ this.pointee = mt.Unmodified;`
	`21`	`+ }`
`14`	`22`	`}`
`15`	`23`
`16`	`24`	`public override bool Equals(object? obj)`