Skip to content

Commit 8321d5f

Browse files
authored
Merge pull request github#6293 from hvitved/csharp/ssa/remove-redundant-conjunct
C#: Remove redundant conjunct in `ssaDefReachesReadWithinBlock`
2 parents 59855de + caf88a2 commit 8321d5f

File tree

4 files changed

+4
-8
lines changed

4 files changed

+4
-8
lines changed

csharp/ql/src/semmle/code/cil/internal/SsaImplCommon.qll

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -284,8 +284,7 @@ private module SsaDefReaches {
284284
predicate ssaDefReachesReadWithinBlock(SourceVariable v, Definition def, BasicBlock bb, int i) {
285285
exists(int rnk |
286286
ssaDefReachesRank(bb, def, rnk, v) and
287-
rnk = ssaRefRank(bb, i, v, SsaRead()) and
288-
variableRead(bb, i, v, _)
287+
rnk = ssaRefRank(bb, i, v, SsaRead())
289288
)
290289
}
291290

csharp/ql/src/semmle/code/csharp/controlflow/internal/pressa/SsaImplCommon.qll

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -284,8 +284,7 @@ private module SsaDefReaches {
284284
predicate ssaDefReachesReadWithinBlock(SourceVariable v, Definition def, BasicBlock bb, int i) {
285285
exists(int rnk |
286286
ssaDefReachesRank(bb, def, rnk, v) and
287-
rnk = ssaRefRank(bb, i, v, SsaRead()) and
288-
variableRead(bb, i, v, _)
287+
rnk = ssaRefRank(bb, i, v, SsaRead())
289288
)
290289
}
291290

csharp/ql/src/semmle/code/csharp/dataflow/internal/SsaImplCommon.qll

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -284,8 +284,7 @@ private module SsaDefReaches {
284284
predicate ssaDefReachesReadWithinBlock(SourceVariable v, Definition def, BasicBlock bb, int i) {
285285
exists(int rnk |
286286
ssaDefReachesRank(bb, def, rnk, v) and
287-
rnk = ssaRefRank(bb, i, v, SsaRead()) and
288-
variableRead(bb, i, v, _)
287+
rnk = ssaRefRank(bb, i, v, SsaRead())
289288
)
290289
}
291290

csharp/ql/src/semmle/code/csharp/dataflow/internal/basessa/SsaImplCommon.qll

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -284,8 +284,7 @@ private module SsaDefReaches {
284284
predicate ssaDefReachesReadWithinBlock(SourceVariable v, Definition def, BasicBlock bb, int i) {
285285
exists(int rnk |
286286
ssaDefReachesRank(bb, def, rnk, v) and
287-
rnk = ssaRefRank(bb, i, v, SsaRead()) and
288-
variableRead(bb, i, v, _)
287+
rnk = ssaRefRank(bb, i, v, SsaRead())
289288
)
290289
}
291290

0 commit comments

Comments
 (0)