Skip to content

Commit 839b88a

Browse files
Formatting, capitalization, and typos
Co-authored-by: Tony Torralba <[email protected]>
1 parent b606271 commit 839b88a

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

java/ql/src/Security/CWE/CWE-094/ArbitraryAPKInstallation.ql

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,10 @@ class UriConstructorMethod extends Method {
6161

6262
/**
6363
* A dataflow source representing the URIs which an APK not controlled by the
64-
* application may come from. Incuding external storage and web URLs.
64+
* application may come from. Including external storage and web URLs.
6565
*/
66-
class ExternalAPKSource extends DataFlow::Node {
67-
ExternalAPKSource() {
66+
class ExternalApkSource extends DataFlow::Node {
67+
ExternalApkSource() {
6868
sourceNode(this, "android-external-storage-dir") or
6969
this.asExpr().(MethodAccess).getMethod() instanceof UriConstructorMethod or
7070
this.asExpr().(StringLiteral).getValue().matches(["file://%", "http://%", "https://%"])
@@ -75,10 +75,10 @@ class ExternalAPKSource extends DataFlow::Node {
7575
* A dataflow configuration for flow from an external source of an APK to the
7676
* `setData[AndType][AndNormalize]` method of an intent.
7777
*/
78-
class APKConfiguration extends DataFlow::Configuration {
79-
APKConfiguration() { this = "APKConfiguration" }
78+
class ApkConfiguration extends DataFlow::Configuration {
79+
ApkConfiguration() { this = "ApkConfiguration" }
8080

81-
override predicate isSource(DataFlow::Node node) { node instanceof ExternalAPKSource }
81+
override predicate isSource(DataFlow::Node node) { node instanceof ExternalApkSource }
8282

8383
override predicate isSink(DataFlow::Node node) {
8484
exists(MethodAccess ma |
@@ -124,6 +124,6 @@ private class PackageArchiveMimeTypeConfiguration extends TaintTracking2::Config
124124
}
125125
}
126126

127-
from DataFlow::PathNode source, DataFlow::PathNode sink, APKConfiguration config
127+
from DataFlow::PathNode source, DataFlow::PathNode sink, ApkConfiguration config
128128
where config.hasFlowPath(source, sink)
129129
select sink.getNode(), source, sink, "Arbitrary Android APK installation."

0 commit comments

Comments
 (0)