@@ -61,10 +61,10 @@ class UriConstructorMethod extends Method {
61
61
62
62
/**
63
63
* A dataflow source representing the URIs which an APK not controlled by the
64
- * application may come from. Incuding external storage and web URLs.
64
+ * application may come from. Including external storage and web URLs.
65
65
*/
66
- class ExternalAPKSource extends DataFlow:: Node {
67
- ExternalAPKSource ( ) {
66
+ class ExternalApkSource extends DataFlow:: Node {
67
+ ExternalApkSource ( ) {
68
68
sourceNode ( this , "android-external-storage-dir" ) or
69
69
this .asExpr ( ) .( MethodAccess ) .getMethod ( ) instanceof UriConstructorMethod or
70
70
this .asExpr ( ) .( StringLiteral ) .getValue ( ) .matches ( [ "file://%" , "http://%" , "https://%" ] )
@@ -75,10 +75,10 @@ class ExternalAPKSource extends DataFlow::Node {
75
75
* A dataflow configuration for flow from an external source of an APK to the
76
76
* `setData[AndType][AndNormalize]` method of an intent.
77
77
*/
78
- class APKConfiguration extends DataFlow:: Configuration {
79
- APKConfiguration ( ) { this = "APKConfiguration " }
78
+ class ApkConfiguration extends DataFlow:: Configuration {
79
+ ApkConfiguration ( ) { this = "ApkConfiguration " }
80
80
81
- override predicate isSource ( DataFlow:: Node node ) { node instanceof ExternalAPKSource }
81
+ override predicate isSource ( DataFlow:: Node node ) { node instanceof ExternalApkSource }
82
82
83
83
override predicate isSink ( DataFlow:: Node node ) {
84
84
exists ( MethodAccess ma |
@@ -124,6 +124,6 @@ private class PackageArchiveMimeTypeConfiguration extends TaintTracking2::Config
124
124
}
125
125
}
126
126
127
- from DataFlow:: PathNode source , DataFlow:: PathNode sink , APKConfiguration config
127
+ from DataFlow:: PathNode source , DataFlow:: PathNode sink , ApkConfiguration config
128
128
where config .hasFlowPath ( source , sink )
129
129
select sink .getNode ( ) , source , sink , "Arbitrary Android APK installation."
0 commit comments