Skip to content

Commit 86bc7d3

Browse files
committed
avoid a ValueNode x TypeTracker join in Hapi::RouteSetup::getARouteHandler
1 parent d35ea7f commit 86bc7d3

File tree

1 file changed

+4
-1
lines changed
  • javascript/ql/src/semmle/javascript/frameworks

1 file changed

+4
-1
lines changed

javascript/ql/src/semmle/javascript/frameworks/Hapi.qll

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -196,11 +196,14 @@ module Hapi {
196196

197197
private DataFlow::SourceNode getARouteHandler(DataFlow::TypeBackTracker t) {
198198
t.start() and
199-
result = handler.flow().getALocalSource()
199+
result = getRouteHandler().getALocalSource()
200200
or
201201
exists(DataFlow::TypeBackTracker t2 | result = getARouteHandler(t2).backtrack(t2, t))
202202
}
203203

204+
pragma[noinline]
205+
private DataFlow::Node getRouteHandler() { result = handler.flow() }
206+
204207
Expr getRouteHandlerExpr() { result = handler }
205208

206209
override Expr getServer() { result = server }

0 commit comments

Comments
 (0)