Merge pull request github#2868 from asger-semmle/js/missing-await-void

Approved by max-schaefer

Author: semmle-qlci

javascript/ql/src/Expressions/MissingAwait.ql

@@ -43,7 +43,10 @@ predicate isBadPromiseContext(Expr expr) {
   or
   expr = any(LogicalBinaryExpr e).getLeftOperand()
   or
-  expr = any(UnaryExpr e).getOperand()
+  exists(UnaryExpr e |
+    expr = e.getOperand() and
+    not e instanceof VoidExpr
+  )
   or
   expr = any(UpdateExpr e).getOperand()
   or

javascript/ql/test/query-tests/Expressions/MissingAwait/tst.js

@@ -61,3 +61,7 @@ function useThingPossiblySync(b) {
 
     return thing + "bar"; // NOT OK - but we don't flag it
 }
+
+function useThingInVoid() {
+    void getThing(); // OK
+}