Singleton set literal fix

raulgarciamsft · raulgarciamsft · commit 8b4826c0b402 · 2023-03-21T08:02:30.000-07:00
Fixing auto-code scanning recommendation
diff --git a/python/ql/src/experimental/Security/CWE-327/Azure/UnsafeUsageOfClientSideEncryptionVersion.ql b/python/ql/src/experimental/Security/CWE-327/Azure/UnsafeUsageOfClientSideEncryptionVersion.ql
@@ -25,7 +25,7 @@ predicate isUnsafeClientSideAzureStorageEncryptionViaAttributes(Call call, AttrN
   |
     s1 in ["key_encryption_key", "key_resolver_function"] and
     s2 in ["ContainerClient", "BlobClient", "BlobServiceClient"] and
-    s3 in ["upload_blob"] and
+    s3 = "upload_blob" and
     n = API::moduleImport("azure").getMember("storage").getMember("blob").getMember(s2).getAMember() and
     startingNode = n.getACall().getReturn().getAValueReachableFromSource().asExpr().getAFlowNode() and
     startingNode.strictlyReaches(ctrlFlowNode) and

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ predicate isUnsafeClientSideAzureStorageEncryptionViaAttributes(Call call, AttrN`
`25`	`25`	`\|`
`26`	`26`	`s1 in ["key_encryption_key", "key_resolver_function"] and`
`27`	`27`	`s2 in ["ContainerClient", "BlobClient", "BlobServiceClient"] and`
`28`		`- s3 in ["upload_blob"] and`
	`28`	`+ s3 = "upload_blob" and`
`29`	`29`	`n = API::moduleImport("azure").getMember("storage").getMember("blob").getMember(s2).getAMember() and`
`30`	`30`	`startingNode = n.getACall().getReturn().getAValueReachableFromSource().asExpr().getAFlowNode() and`
`31`	`31`	`startingNode.strictlyReaches(ctrlFlowNode) and`