fix bad join by removing bad recursion

erik-krogh · erik-krogh · commit 8b99e8af889f · 2023-03-13T17:34:11.000+01:00
diff --git a/ruby/ql/lib/codeql/ruby/frameworks/core/Kernel.qll b/ruby/ql/lib/codeql/ruby/frameworks/core/Kernel.qll
@@ -205,7 +205,7 @@ module Kernel {
   private class KernelArraySummary extends SummarizedCallable {
     KernelArraySummary() { this = "Array()" }
 
-    override MethodCall getACallSimple() {
+    override MethodCall getACall() {
       result.getMethodName() = "Array" and
       // I have to have a simplified "KernelMethodCall" implementation inlined here, because relying on `UnknownMethodCall` results in non-monotonic recursion (even if using `getACall`).
       (

Original file line number	Diff line number	Diff line change
`@@ -205,7 +205,7 @@ module Kernel {`
`205`	`205`	`private class KernelArraySummary extends SummarizedCallable {`
`206`	`206`	`KernelArraySummary() { this = "Array()" }`
`207`	`207`
`208`		`- override MethodCall getACallSimple() {`
	`208`	`+ override MethodCall getACall() {`
`209`	`209`	`result.getMethodName() = "Array" and`
`210`	`210`	// I have to have a simplified "KernelMethodCall" implementation inlined here, because relying on `UnknownMethodCall` results in non-monotonic recursion (even if using `getACall`).
`211`	`211`	`(`