Refactor Calls to use ApiGraphs

Author: jorgectf

python/ql/src/experimental/semmle/python/frameworks/Stdlib.qll

@@ -9,3 +9,60 @@ private import semmle.python.dataflow.new.TaintTracking
 private import semmle.python.dataflow.new.RemoteFlowSources
 private import experimental.semmle.python.Concepts
 private import semmle.python.ApiGraphs
+
+private module LDAP {
+  private module LDAP2 {
+    private class LDAP2QueryMethods extends string {
+      LDAP2QueryMethods() {
+        this in ["search", "search_s", "search_st", "search_ext", "search_ext_s"]
+      }
+    }
+
+    class LDAP2Bind extends DataFlow::CallCfgNode, LDAPBind::Range {
+      DataFlow::Node queryNode;
+
+      LDAP2Bind() {
+        exists(
+          DataFlow::AttrRead bindMethod, DataFlow::CallCfgNode searchCall,
+          DataFlow::AttrRead searchMethod
+        |
+          this.getFunction() = bindMethod and
+          API::moduleImport("ldap").getMember("initialize").getACall() =
+            bindMethod.getObject().getALocalSource() and
+          bindMethod.getAttributeName().matches("%bind%") and
+          searchCall.getFunction() = searchMethod and
+          bindMethod.getObject().getALocalSource() = searchMethod.getObject().getALocalSource() and
+          searchMethod.getAttributeName() instanceof LDAP2QueryMethods and
+          (
+            queryNode = searchCall.getArg(2) or
+            queryNode = searchCall.getArgByName("filterstr")
+          )
+        )
+      }
+
+      override DataFlow::Node getPasswordNode() { result = this.getArg(1) }
+
+      override DataFlow::Node getQueryNode() { result = queryNode }
+    }
+  }
+
+  private module LDAP3 {
+    class LDAP3Bind extends DataFlow::CallCfgNode, LDAPBind::Range {
+      DataFlow::Node queryNode;
+
+      LDAP3Bind() {
+        exists(DataFlow::CallCfgNode searchCall, DataFlow::AttrRead searchMethod |
+          this = API::moduleImport("ldap3").getMember("Connection").getACall() and
+          searchMethod.getObject().getALocalSource() = this and
+          searchCall.getFunction() = searchMethod and
+          searchMethod.getAttributeName() = "search" and
+          queryNode = searchCall.getArg(1)
+        )
+      }
+
+      override DataFlow::Node getPasswordNode() { result = this.getArgByName("password") }
+
+      override DataFlow::Node getQueryNode() { result = queryNode }
+    }
+  }
+}