Skip to content

Commit 8ce5c46

Browse files
committed
Python: Minor refactor
modName/clsName _is_ shorter, but also looks way worse :D
1 parent a9527fd commit 8ce5c46

File tree

1 file changed

+9
-8
lines changed

1 file changed

+9
-8
lines changed

python/ql/src/semmle/python/frameworks/Django.qll

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2081,20 +2081,21 @@ private module Django {
20812081
module Field {
20822082
/** Gets a reference to the `django.forms.fields.Field` class or any subclass. */
20832083
API::Node subclassRef() {
2084-
exists(string modName, string clsName |
2084+
exists(string moduleName, string className |
20852085
// canonical definition
20862086
result =
20872087
API::moduleImport("django")
20882088
.getMember("forms")
2089-
.getMember(modName)
2090-
.getMember(clsName)
2089+
.getMember(moduleName)
2090+
.getMember(className)
20912091
.getASubclass*()
20922092
or
20932093
// alias from `django.forms`
2094-
result = API::moduleImport("django").getMember("forms").getMember(clsName).getASubclass*()
2094+
result =
2095+
API::moduleImport("django").getMember("forms").getMember(className).getASubclass*()
20952096
|
2096-
modName = "fields" and
2097-
clsName in [
2097+
moduleName = "fields" and
2098+
className in [
20982099
"Field",
20992100
// Known subclasses
21002101
"BooleanField", "IntegerField", "CharField", "SlugField", "DateTimeField",
@@ -2106,8 +2107,8 @@ private module Django {
21062107
]
21072108
or
21082109
// Known subclasses from `django.forms.models`
2109-
modName = "models" and
2110-
clsName in ["ModelChoiceField", "ModelMultipleChoiceField", "InlineForeignKeyField"]
2110+
moduleName = "models" and
2111+
className in ["ModelChoiceField", "ModelMultipleChoiceField", "InlineForeignKeyField"]
21112112
)
21122113
or
21132114
// other Field subclasses defined in Django

0 commit comments

Comments
 (0)