Apply suggestions from code review

Co-authored-by: Jami <[email protected]>

Author: egregius313

java/ql/src/Security/CWE/CWE-094/ArbitraryAPKInstallation.qhelp

@@ -58,16 +58,16 @@
 
   <references>
     <li>
-      Intent.ACTION_INSTALL_PACKAGE: <a href="https://developer.android.com/reference/android/content/Intent#ACTION_INSTALL_PACKAGE"></a>.
+      Android Developers: <a href="https://developer.android.com/reference/android/content/Intent#ACTION_INSTALL_PACKAGE">Intent.ACTION_INSTALL_PACKAGE</a>.
     </li>
     <li>
-      Android Manifest Permission to Install Packages: <a href="https://developer.android.com/reference/android/Manifest.permission#REQUEST_INSTALL_PACKAGES"></a>.
+      Android Developers: <a href="https://developer.android.com/reference/android/Manifest.permission#REQUEST_INSTALL_PACKAGES">Manifest.permission.REQUEST_INSTALL_PACKAGES</a>.
     </li>
     <li>
-      PackageInstaller: <a href="https://developer.android.com/reference/android/content/pm/PackageInstaller"></a>.
+     Android Developers: <a href="https://developer.android.com/reference/android/content/pm/PackageInstaller">PackageInstaller</a>.
     </li>
     <li>
-      FileProvider: <a href="https://developer.android.com/reference/androidx/core/content/FileProvider"></a>.
+      Android Developers: <a href="https://developer.android.com/reference/androidx/core/content/FileProvider">FileProvider</a>.
     </li>
   </references>
 </qhelp>

java/ql/src/Security/CWE/CWE-094/ArbitraryAPKInstallation.ql

@@ -71,7 +71,7 @@ class SetDataSink extends DataFlow::ExprNode {
 /** A method that generates a URI. */
 class UriConstructorMethod extends Method {
   UriConstructorMethod() {
-    this.hasQualifiedName("android.net", "Uri", [/*"parse",*/ "fromFile", "fromParts"]) or
+    this.hasQualifiedName("android.net", "Uri", ["fromFile", "fromParts"]) or
     this.hasQualifiedName("androidx.core.content", "FileProvider", "getUriForFile")
   }
 }

java/ql/src/change-notes/2023-01-19-arbitrary-apk-installation.md

@@ -1,5 +1,5 @@
 ---
 category: newQuery
 ---
-* Added a new query `java/android/arbitrary-apk-installation` to detect installation of APKs from untrusted sources.
+* Added a new query, `java/android/arbitrary-apk-installation`, to detect installation of APKs from untrusted sources.