Skip to content

Commit 8f46700

Browse files
committed
Python: More review suggestions
1 parent 63b732c commit 8f46700

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed
Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
lgtm,codescanning
2-
* Make `ParameterNode` extend `LocalSourceNode`, thus making members like `flowsTo` available.
3-
* Add member predicate `taintFlowsTo` to `LocalSourceNode` facilitating smoother syntax for local taint tracking.
4-
* Add member `getALocalTaintSource` to `DataFlow::Node` facilitating smoother syntax for local taint tracking.
5-
* Add predicate `parameterNode` to map from a `Parameter` to a data-flow node.
2+
* The class ParameterNode now extends LocalSourceNode, thus making methods like flowsTo available.
3+
* Local taint tracking can now be performed using the `taintFlowsTo` method on the `LocalSourceNode` class. Conversely, the new member predicate `getALocalTaintSource` can be called on a `DataFlow::Node` to obtain a `LocalSourceNode` from which taint can be tracked locally to that data-flow node.
4+
* The new predicate `parameterNode` can now be used to map from a `Parameter` to a data-flow node.

python/ql/src/semmle/python/dataflow/new/internal/DataFlowPublic.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ class Node extends TNode {
136136
LocalSourceNode backtrack(TypeBackTracker t2, TypeBackTracker t) { t2 = t.step(result, this) }
137137

138138
/**
139-
* Gets a local source node from which data may flow to this node in zero or more local steps.
139+
* Gets a local source node from which data may flow to this node in zero or more local data-flow steps.
140140
*/
141141
LocalSourceNode getALocalSource() { result.flowsTo(this) }
142142

0 commit comments

Comments
 (0)