Merge pull request github#2964 from BekaValentine/python-objectapi-to-valueapi-notimplemented

tausbn · web-flow · commit 9068040097bc · 2020-03-03T18:36:14.000+01:00
Python: ObjectAPI to ValueAPI: NotImplemented
diff --git a/python/ql/src/Exceptions/NotImplemented.qll b/python/ql/src/Exceptions/NotImplemented.qll
@@ -3,7 +3,7 @@ import python
 
 /** Holds if `notimpl` refers to `NotImplemented` or `NotImplemented()` in the `raise` statement */
 predicate use_of_not_implemented_in_raise(Raise raise, Expr notimpl) {
-    notimpl.refersTo(Object::notImplemented()) and
+    notimpl.pointsTo(Value::named("NotImplemented")) and
     (
         notimpl = raise.getException() or
         notimpl = raise.getException().(Call).getFunc()

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,7 @@ import python`
`3`	`3`
`4`	`4`	/** Holds if `notimpl` refers to `NotImplemented` or `NotImplemented()` in the `raise` statement */
`5`	`5`	`predicate use_of_not_implemented_in_raise(Raise raise, Expr notimpl) {`
`6`		`- notimpl.refersTo(Object::notImplemented()) and`
	`6`	`+ notimpl.pointsTo(Value::named("NotImplemented")) and`
`7`	`7`	`(`
`8`	`8`	`notimpl = raise.getException() or`
`9`	`9`	`notimpl = raise.getException().(Call).getFunc()`