Merge pull request github#5524 from hvitved/csharp/cleanup

C#: Remove legacy queries and `@precision` tags from metric queries

Author: hvitved

config/identical-files.json

@@ -376,7 +376,6 @@
   ],
   "DuplicationProblems.inc.qhelp": [
     "cpp/ql/src/Metrics/Files/DuplicationProblems.inc.qhelp",
-    "csharp/ql/src/Metrics/Files/DuplicationProblems.inc.qhelp",
     "javascript/ql/src/Metrics/DuplicationProblems.inc.qhelp",
     "python/ql/src/Metrics/DuplicationProblems.inc.qhelp"
   ],

csharp/change-notes/2021-03-24-remove-legacy-queries.md

@@ -0,0 +1,2 @@
+lgtm,codescanning
+* Legacy queries in the folders `external` and `filters` have all been removed.

csharp/change-notes/2021-03-24-remove-vuln-package-query.md

@@ -0,0 +1,2 @@
+lgtm,codescanning
+* The query `VulnerablePackage.ql` has been removed.

csharp/ql/src/Metrics/Dependencies/ExternalDependencies.ql

@@ -5,7 +5,6 @@
  * @kind treemap
  * @treemap.warnOn highValues
  * @metricType externalDependency
- * @precision medium
  * @id cs/external-dependencies
  */
 

csharp/ql/src/Metrics/Files/DuplicationProblems.inc.qhelp

@@ -5,7 +5,6 @@
  * @treemap.warnOn highValues
  * @metricType file
  * @metricAggregate avg sum max
- * @precision very-high
  * @id cs/lines-of-code-in-files
  * @tags maintainability
  *       complexity

csharp/ql/src/Metrics/Files/FLinesOfCode.ql

@@ -5,7 +5,6 @@
  * @treemap.warnOn lowValues
  * @metricType file
  * @metricAggregate avg sum max
- * @precision very-high
  * @id cs/lines-of-comments-in-files
  * @tags maintainability
  *       documentation

csharp/ql/src/Metrics/Files/FLinesOfComment.ql

@@ -5,7 +5,6 @@
  * @treemap.warnOn highValues
  * @metricType file
  * @metricAggregate avg sum max
- * @precision high
  * @id cs/lines-of-commented-out-code-in-files
  * @tags maintainability
  *       documentation