Skip to content

Commit 9556937

Browse files
committed
Python: address review comments
1 parent 8d49ad7 commit 9556937

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

python/ql/test/experimental/dataflow/coverage/classes.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1041,7 +1041,9 @@ def test_index():
10411041
with_index = With_index()
10421042
operator.index(with_index)
10431043

1044-
# make With_index subscriptable to test slicing
1044+
def test_index_slicing():
1045+
with_index = With_index()
1046+
[0][with_index:1]
10451047

10461048
def test_index_bin():
10471049
with_index = With_index()

python/ql/test/experimental/dataflow/coverage/classesCallGraph.ql

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,5 @@ where
66
sink.getLocation().getFile().getBaseName() = "classes.py" and
77
exists(CallGraphConfig cfg | cfg.hasFlow(source, sink))
88
select source, sink
9-
// Rewrite this to just have 1-step paths?
9+
// Ideally, we would just have 1-step paths either from argument to parameter
10+
// or from return to call. This gives a bit more, so should be rewritten.

0 commit comments

Comments
 (0)