Skip to content

Commit 9563114

Browse files
committed
fixed bad SourceNode X SourceNode join in HTTP model
1 parent 8adaee0 commit 9563114

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

javascript/ql/src/semmle/javascript/frameworks/Express.qll

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -688,8 +688,7 @@ module Express {
688688
override RouteHandler getRouteHandler() { result = rh }
689689

690690
override Expr getNameExpr() {
691-
exists(DataFlow::PropWrite write |
692-
getAHeaderSource().flowsTo(write.getBase()) and
691+
exists(DataFlow::PropWrite write | getAHeaderSource().getAPropertyWrite() = write |
693692
result = write.getPropertyNameExpr()
694693
)
695694
}

javascript/ql/src/semmle/javascript/frameworks/Fastify.qll

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -283,8 +283,7 @@ module Fastify {
283283
override RouteHandler getRouteHandler() { result = rh }
284284

285285
override Expr getNameExpr() {
286-
exists(DataFlow::PropWrite write |
287-
this.getAHeaderSource().flowsTo(write.getBase()) and
286+
exists(DataFlow::PropWrite write | getAHeaderSource().getAPropertyWrite() = write |
288287
result = write.getPropertyNameExpr()
289288
)
290289
}

0 commit comments

Comments
 (0)