Skip to content

Commit 95a7b16

Browse files
committed
add support for the lie polyfill
1 parent 085efe5 commit 95a7b16

File tree

4 files changed

+12
-1
lines changed

4 files changed

+12
-1
lines changed

javascript/change-notes/2021-06-18-promises.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,4 +11,5 @@ lgtm,codescanning
1111
[pinkie-promise](https://npmjs.com/package/pinkie-promise),
1212
[pinkie](https://npmjs.com/package/pinkie),
1313
[synchronous-promise](https://npmjs.com/package/synchronous-promise),
14-
[any-promise](https://npmjs.com/package/any-promise)
14+
[any-promise](https://npmjs.com/package/any-promise),
15+
[lie](https://npmjs.com/package/lie)

javascript/ql/src/semmle/javascript/Promises.qll

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,8 @@ private DataFlow::SourceNode getAPromiseObject() {
9191
result = DataFlow::moduleMember("synchronous-promise", "SynchronousPromise")
9292
or
9393
result = DataFlow::moduleImport("any-promise")
94+
or
95+
result = DataFlow::moduleImport("lie")
9496
}
9597

9698
/**

javascript/ql/test/library-tests/Promises/promises.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -146,4 +146,9 @@
146146
(function() {
147147
var Promise = require('any-promise');
148148
return new Promise(function(resolve, reject){})
149+
})();
150+
151+
(function() {
152+
var Promise = require('lie');
153+
var promise = Promise.resolve(source);
149154
})();

javascript/ql/test/library-tests/Promises/tests.expected

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ test_ResolvedPromiseDefinition
4444
| promises.js:119:3:119:25 | Promise ... source) | promises.js:119:19:119:24 | source |
4545
| promises.js:125:20:125:39 | when.resolve(source) | promises.js:125:33:125:38 | source |
4646
| promises.js:143:17:143:50 | Synchro ... source) | promises.js:143:44:143:49 | source |
47+
| promises.js:153:17:153:39 | Promise ... source) | promises.js:153:33:153:38 | source |
4748
test_PromiseDefinition_getARejectHandler
4849
| flow.js:26:2:26:49 | new Pro ... ource)) | flow.js:26:69:26:80 | y => sink(y) |
4950
| flow.js:32:2:32:49 | new Pro ... ource)) | flow.js:32:57:32:68 | x => sink(x) |
@@ -449,3 +450,5 @@ typetrack
449450
| promises.js:135:3:137:4 | new Pro ... );\\n }) | promises.js:136:13:136:16 | data | store $PromiseResolveField$ |
450451
| promises.js:143:17:143:50 | Synchro ... source) | promises.js:143:44:143:49 | source | copy $PromiseResolveField$ |
451452
| promises.js:143:17:143:50 | Synchro ... source) | promises.js:143:44:143:49 | source | store $PromiseResolveField$ |
453+
| promises.js:153:17:153:39 | Promise ... source) | promises.js:153:33:153:38 | source | copy $PromiseResolveField$ |
454+
| promises.js:153:17:153:39 | Promise ... source) | promises.js:153:33:153:38 | source | store $PromiseResolveField$ |

0 commit comments

Comments
 (0)