Report error even if interpretElement resolves to a non-Callable Element

smowton · aschackmull · web-flow · commit 97694bc9a1e7 · 2021-07-13T16:16:01.000+01:00
Co-authored-by: Anders Schack-Mulligen &lt;aschackmull@users.noreply.github.com&gt;
diff --git a/java/ql/src/utils/GenerateFlowTestCase.qll b/java/ql/src/utils/GenerateFlowTestCase.qll
@@ -41,7 +41,7 @@ query string getAParseFailure(string reason) {
       string namespace, string type, boolean subtypes, string name, string signature, string ext
     |
       summaryModel(namespace, type, subtypes, name, signature, ext, _, _, _, result) and
-      not exists(interpretElement(namespace, type, subtypes, name, signature, ext)) and
+      not interpretElement(namespace, type, subtypes, name, signature, ext) instanceof Callable and
       reason = "callable could not be resolved"
     )
     or

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ query string getAParseFailure(string reason) {`
`41`	`41`	`string namespace, string type, boolean subtypes, string name, string signature, string ext`
`42`	`42`	`\|`
`43`	`43`	`summaryModel(namespace, type, subtypes, name, signature, ext, _, _, _, result) and`
`44`		`- not exists(interpretElement(namespace, type, subtypes, name, signature, ext)) and`
	`44`	`+ not interpretElement(namespace, type, subtypes, name, signature, ext) instanceof Callable and`
`45`	`45`	`reason = "callable could not be resolved"`
`46`	`46`	`)`
`47`	`47`	`or`