Merge pull request github#5026 from MathiasVP/remove-linear-scan-of-functions

C++: Remove linear scan of functions table

Author: geoffw0

cpp/ql/src/semmle/code/cpp/models/implementations/Strcpy.qll

@@ -40,9 +40,7 @@ class StrcpyFunction extends ArrayFunction, DataFlowFunction, TaintFunction, Sid
   /**
    * Holds if this is one of the `strcpy_s` variants.
    */
-  private predicate isSVariant() {
-    exists(string name | name = getName() | name.suffix(name.length() - 2) = "_s")
-  }
+  private predicate isSVariant() { getName().matches("%\\_s") }
 
   /**
    * Gets the index of the parameter that is the maximum size of the copy (in characters).