@@ -56,27 +56,27 @@ private class CompareSink extends UseOfLessTrustedSink {
56
56
ma .getMethod ( ) .getDeclaringType ( ) instanceof TypeString and
57
57
ma .getMethod ( ) .getNumberOfParameters ( ) = 1 and
58
58
ma .getQualifier ( ) = this .asExpr ( ) and
59
- ma .getArgument ( 0 ) .( CompileTimeConstantExpr ) .getStringValue ( ) .toLowerCase ( ) in [ "" , "unknown" ]
59
+ not ma .getArgument ( 0 ) .( CompileTimeConstantExpr ) .getStringValue ( ) .toLowerCase ( ) in [ "" , "unknown" ]
60
60
)
61
61
or
62
- exists ( MethodAccess ma , int i |
62
+ exists ( MethodAccess ma |
63
63
ma .getMethod ( ) .hasName ( "startsWith" ) and
64
64
ma .getMethod ( )
65
65
.getDeclaringType ( )
66
66
.hasQualifiedName ( [ "org.apache.commons.lang3" , "org.apache.commons.lang" ] , "StringUtils" ) and
67
67
ma .getMethod ( ) .getNumberOfParameters ( ) = 2 and
68
- ma .getArgument ( i ) = this .asExpr ( ) and
69
- ma .getArgument ( 1 - i ) .( CompileTimeConstantExpr ) .getStringValue ( ) != ""
68
+ ma .getAnArgument ( ) = this .asExpr ( ) and
69
+ ma .getAnArgument ( ) .( CompileTimeConstantExpr ) .getStringValue ( ) != ""
70
70
)
71
71
or
72
- exists ( MethodAccess ma , int i |
72
+ exists ( MethodAccess ma |
73
73
ma .getMethod ( ) .getName ( ) in [ "equals" , "equalsIgnoreCase" ] and
74
74
ma .getMethod ( )
75
75
.getDeclaringType ( )
76
76
.hasQualifiedName ( [ "org.apache.commons.lang3" , "org.apache.commons.lang" ] , "StringUtils" ) and
77
77
ma .getMethod ( ) .getNumberOfParameters ( ) = 2 and
78
- ma .getArgument ( i ) = this .asExpr ( ) and
79
- not ma .getArgument ( 1 - i ) .( CompileTimeConstantExpr ) .getStringValue ( ) .toLowerCase ( ) in [
78
+ ma .getAnArgument ( ) = this .asExpr ( ) and
79
+ not ma .getAnArgument ( ) .( CompileTimeConstantExpr ) .getStringValue ( ) .toLowerCase ( ) in [
80
80
"" , "unknown" , ":"
81
81
]
82
82
)
0 commit comments