Skip to content

Commit 9b953cf

Browse files
Apply suggestions from code review
Co-authored-by: Chris Smowton <[email protected]>
1 parent ad54c9d commit 9b953cf

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

java/ql/src/experimental/Security/CWE/CWE-208/NonConstantTimeCheckOnSignatureQuery.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ private predicate looksLikeConstant(Expr expr) {
238238
* Holds if `firstObject` and `secondObject` are compared using a method
239239
* that does not use a constant-time algorithm, for example, `String.equals()`.
240240
*/
241-
private predicate isNonConstantEqualsCall(Expr firstObject, Expr secondObject) {
241+
private predicate isNonConstantTimeEqualsCall(Expr firstObject, Expr secondObject) {
242242
exists(NonConstantTimeEqualsCall call |
243243
firstObject = call.getQualifier() and
244244
secondObject = call.getAnArgument()

java/ql/src/semmle/code/java/dataflow/ExternalFlow.qll

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -257,7 +257,6 @@ private predicate sinkModelCsv(string row) {
257257
]
258258
}
259259

260-
// TODO: add ByteBuffer
261260
private predicate summaryModelCsv(string row) {
262261
row =
263262
[

0 commit comments

Comments
 (0)