Skip to content

Commit 9cde13b

Browse files
committed
Note spurious results that stem from weak updates to synthetic fields.
1 parent 1bbac74 commit 9cde13b

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

java/ql/test/library-tests/frameworks/apache-commons-lang3/MutableTest.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,10 @@ void test() throws Exception {
2121
sink(taintedAlias.getValue()); // $hasValueFlow
2222
sink(taintSet.getValue()); // $hasValueFlow
2323
sink(taintSetAlias.getValue()); // $hasValueFlow
24-
sink(taintCleared.getValue());
25-
sink(taintClearedAlias.getValue());
24+
// These two cases don't work currently because synthetic fields are always weakly updated,
25+
// so no taint clearing takes place.
26+
sink(taintCleared.getValue()); // $SPURIOUS: hasValueFlow
27+
sink(taintClearedAlias.getValue()); // $SPURIOUS: hasValueFlow
2628

2729
}
2830
}

0 commit comments

Comments
 (0)