C++: Bug fix.

geoffw0 · geoffw0 · commit 9cdf8389815e · 2021-05-13T16:20:52.000+01:00
diff --git a/cpp/ql/src/Security/CWE/CWE-327/BrokenCryptoAlgorithm.ql b/cpp/ql/src/Security/CWE/CWE-327/BrokenCryptoAlgorithm.ql
@@ -31,7 +31,8 @@ Function getAnInsecureEncryptionFunction() {
 Function getAdditionalEvidenceFunction() {
   (
     isEncryptionAdditionalEvidence(result.getName()) or
-    isEncryptionAdditionalEvidence(result.getAParameter().getName())
+    isEncryptionAdditionalEvidence(result.getAParameter().getName()) or
+    isInsecureEncryption(result.getDeclaringType().getName())
   ) and
   exists(result.getACallToThisFunction())
 }

Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,8 @@ Function getAnInsecureEncryptionFunction() {`
`31`	`31`	`Function getAdditionalEvidenceFunction() {`
`32`	`32`	`(`
`33`	`33`	`isEncryptionAdditionalEvidence(result.getName()) or`
`34`		`- isEncryptionAdditionalEvidence(result.getAParameter().getName())`
	`34`	`+ isEncryptionAdditionalEvidence(result.getAParameter().getName()) or`
	`35`	`+ isInsecureEncryption(result.getDeclaringType().getName())`
`35`	`36`	`) and`
`36`	`37`	`exists(result.getACallToThisFunction())`
`37`	`38`	`}`