Skip to content

Commit 9d7d6b3

Browse files
Small fixes based on feedback
1 parent 5387294 commit 9d7d6b3

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

csharp/ql/src/experimental/Security Features/Serialization/DataSetSerialization.qll

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ class UnsafeXmlSerializerImplementation extends SerializableClass {
7979
}
8080

8181
/**
82-
* Method that may be unsafe when used to serialize DataSet and DataTable related types
82+
* Method that may be unsafe when used to deserialize DataSet and DataTable related types
8383
*/
8484
class UnsafeXmlReadMethod extends Method {
8585
UnsafeXmlReadMethod() {
@@ -91,8 +91,7 @@ class UnsafeXmlReadMethod extends Method {
9191
this.getName().matches("ReadXml%") and
9292
exists( Class c |
9393
c.getAMethod() = this |
94-
c.getABaseType*() instanceof DataSetOrTableRelatedClass or
95-
c.getABaseType*() instanceof DataSetOrTableRelatedClass
94+
c.getABaseType*() instanceof DataSetOrTableRelatedClass
9695
)
9796
)
9897
}

0 commit comments

Comments
 (0)