Skip to content

Commit 9e87f4e

Browse files
haby0smowton
andauthored
Update java/ql/src/experimental/Security/CWE/CWE-348/UseOfLessTrustedSource.ql
Co-authored-by: Chris Smowton <[email protected]>
1 parent 408dd31 commit 9e87f4e

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

java/ql/src/experimental/Security/CWE/CWE-348/UseOfLessTrustedSource.ql

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@ class UseOfLessTrustedSourceConfig extends TaintTracking::Configuration {
2727
override predicate isSink(DataFlow::Node sink) { sink instanceof UseOfLessTrustedSink }
2828

2929
/**
30-
* When using `,` split request data and not taking the first value of the array, it is considered as `good`.
30+
* Splitting a header value by `,` and taking an entry other than the first is sanitizing, because
31+
* later entries may originate from more-trustworthy intermediate proxies, not the original client.
3132
*/
3233
override predicate isSanitizer(DataFlow::Node node) {
3334
exists(ArrayAccess aa, MethodAccess ma | aa.getArray() = ma |

0 commit comments

Comments
 (0)