JS: address review feedback

Author: esbena

javascript/ql/src/experimental/poi/PoI.qll

@@ -3,7 +3,7 @@
  * in an unknown code base.
  *
  * To use this module, subclass the
- * `PoI` class, override *one* of its `is` predicates, and use
+ * `ActivePoI` class, override *one* of its `is` predicates, and use
  * `alertQuery` as a `@kind problem` query .  This will present
  * the desired points of interest as alerts that are easily browsable
  * in a codeql IDE.  By itself, this is no different from an ordinary
@@ -14,7 +14,7 @@
  * - this module comes with a collection of standard points of interest (see `StandardPoIs`)
  *
  * A global configuration for the points of interest (see
- * `PoIConfg`) can be used to easily manage multiple points of
+ * `PoIConfiguration`) can be used to easily manage multiple points of
  * interests, and to restrict the points of interest to specific
  * corners of the code base.
  *
@@ -300,15 +300,11 @@ predicate alertQuery(Locatable l1line, string msg, Node l2, string s2, Node l3,
     (
       not exists(PoIConfiguration cfg) and
       PoIConfigDefaults::enabled(poi) and
-      PoIConfigDefaults::shown(l1) and
-      PoIConfigDefaults::shown(l2) and
-      PoIConfigDefaults::shown(l3)
+      PoIConfigDefaults::shown(l1)
       or
       exists(PoIConfiguration cfg |
         cfg.enabled(poi) and
-        cfg.shown(l1) and
-        cfg.shown(l2) and
-        cfg.shown(l3)
+        cfg.shown(l1)
       )
     ) and
     m = poi.getFormat() and

javascript/ql/test/experimental/PoI/CommandInjectionPoIConfiguration.ql

@@ -8,10 +8,6 @@ import semmle.javascript.security.dataflow.CommandInjection
 import semmle.javascript.security.dataflow.IndirectCommandInjection
 import semmle.javascript.security.dataflow.ShellCommandInjectionFromEnvironment
 
-class Config extends PoIConfiguration {
-  Config() { this = "Config" }
-
-  override predicate enabled(PoI poi) { poi instanceof DataFlowConfigurationPoI }
-}
+class MyDataFlowConfigurationPoIs extends DataFlowConfigurationPoI, ActivePoI { }
 
 query predicate problems = alertQuery/6;

javascript/ql/test/experimental/PoI/ServerPoIConfiguration.ql

@@ -5,10 +5,6 @@
 import javascript
 import experimental.poi.PoI
 
-class Config extends PoIConfiguration {
-  Config() { this = "Config" }
-
-  override predicate enabled(PoI poi) { poi instanceof ServerRelatedPoI }
-}
+class MyServerRelatedPoIs extends ServerRelatedPoI, ActivePoI { }
 
 query predicate problems = alertQuery/6;

javascript/ql/test/experimental/PoI/TaintedPathPoIConfiguration.ql

@@ -6,10 +6,6 @@ import javascript
 import experimental.poi.PoI
 import semmle.javascript.security.dataflow.TaintedPath
 
-class Config extends PoIConfiguration {
-  Config() { this = "Config" }
-
-  override predicate enabled(PoI poi) { poi instanceof DataFlowConfigurationPoI }
-}
+class MyDataflowRelatedPoIs extends DataFlowConfigurationPoI, ActivePoI { }
 
 query predicate problems = alertQuery/6;

javascript/ql/test/experimental/PoI/TestStandardPoIs.ql

@@ -5,10 +5,6 @@
 import javascript
 import experimental.poi.PoI
 
-class Config extends PoIConfiguration {
-  Config() { this = "Config" }
-
-  override predicate enabled(PoI poi) { poi instanceof UnpromotedRouteHandlerPoI }
-}
+class MyUnpromotedRouteHandlerPoIs extends UnpromotedRouteHandlerPoI, ActivePoI { }
 
 query predicate problems = alertQuery/6;

javascript/ql/test/experimental/PoI/XssPoIConfiguration.ql

@@ -9,10 +9,6 @@ import semmle.javascript.security.dataflow.StoredXss
 import semmle.javascript.security.dataflow.DomBasedXss
 import semmle.javascript.security.dataflow.ExceptionXss
 
-class Config extends PoIConfiguration {
-  Config() { this = "Config" }
-
-  override predicate enabled(PoI poi) { poi instanceof DataFlowConfigurationPoI }
-}
+class MyDataFlowConfigurationPoIs extends DataFlowConfigurationPoI, ActivePoI { }
 
 query predicate problems = alertQuery/6;