Skip to content

Commit a18e0b3

Browse files
committed
JS: simplify sequelize model
1 parent f52c827 commit a18e0b3

File tree

1 file changed

+6
-9
lines changed
  • javascript/ql/src/semmle/javascript/frameworks

1 file changed

+6
-9
lines changed

javascript/ql/src/semmle/javascript/frameworks/SQL.qll

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -315,25 +315,22 @@ private module MsSql {
315315
* Provides classes modelling the `sequelize` package.
316316
*/
317317
private module Sequelize {
318-
/** Gets an import of the `sequelize` module. */
319-
DataFlow::SourceNode sequelize() { result = DataFlow::moduleImport("sequelize") }
320-
321318
/** Gets a node referring to an instance of the `Sequelize` class. */
322-
private DataFlow::SourceNode newSequelize(DataFlow::TypeTracker t) {
319+
private DataFlow::SourceNode sequelize(DataFlow::TypeTracker t) {
323320
t.start() and
324-
result = sequelize().getAnInstantiation()
321+
result = DataFlow::moduleImport("sequelize").getAnInstantiation()
325322
or
326-
exists(DataFlow::TypeTracker t2 | result = newSequelize(t2).track(t2, t))
323+
exists(DataFlow::TypeTracker t2 | result = sequelize(t2).track(t2, t))
327324
}
328325

329326
/** Gets a node referring to an instance of the `Sequelize` class. */
330-
DataFlow::SourceNode newSequelize() { result = newSequelize(DataFlow::TypeTracker::end()) }
327+
DataFlow::SourceNode sequelize() { result = sequelize(DataFlow::TypeTracker::end()) }
331328

332329
/** A call to `Sequelize.query`. */
333330
private class QueryCall extends DatabaseAccess, DataFlow::ValueNode {
334331
override MethodCallExpr astNode;
335332

336-
QueryCall() { this = newSequelize().getAMethodCall("query") }
333+
QueryCall() { this = sequelize().getAMethodCall("query") }
337334

338335
override DataFlow::Node getAQueryArgument() {
339336
result = DataFlow::valueNode(astNode.getArgument(0))
@@ -354,7 +351,7 @@ private module Sequelize {
354351

355352
Credentials() {
356353
exists(NewExpr ne, string prop |
357-
ne = newSequelize().asExpr() and
354+
ne = sequelize().asExpr() and
358355
(
359356
this = ne.getArgument(1) and prop = "username"
360357
or

0 commit comments

Comments
 (0)