Skip to content

Commit a1d229e

Browse files
committed
Python: Remove references to LGTM
1 parent 4a37c01 commit a1d229e

File tree

11 files changed

+9
-21
lines changed

11 files changed

+9
-21
lines changed

python/ql/test/3/library-tests/PointsTo/typehints/test.py

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,3 @@ def bar(s:set)->Set:
88

99
t1 = Optional[Optional[int]]
1010
t2 = Optional[int][int]
11-
12-
# ODASA-8075
13-
# Commented out until the fix has been pushed to LGTM.com
14-
#class baz():
15-
# pass
16-
#
17-
#while True:
18-
# baz = baz[baz]

python/ql/test/library-tests/regex/charSetTest.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,12 @@
2525

2626
re.compile("]]][[[[]") #$ charSet=3:8
2727

28-
29-
#ODASA-3985
3028
#Half Surrogate pairs
3129
re.compile(u'[\uD800-\uDBFF][\uDC00-\uDFFF]') #$ charSet=0:5 charSet=5:10
3230
#Outside BMP
3331
re.compile(u'[\U00010000-\U0010ffff]') #$ charSet=0:5
3432

35-
#Misparsed on LGTM
33+
#Misparsed
3634
re.compile(r"\[(?P<txt>[^[]*)\]\((?P<uri>[^)]*)") #$ charSet=10:14 charSet=28:32
3735

3836
# parses wrongly, sees this \|/ as a char set start

python/ql/test/library-tests/regex/escapedCharacterTest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
#Outside BMP
2222
re.compile(u'[\U00010000-\U0010ffff]') # not escapes
2323

24-
#Misparsed on LGTM
24+
#Misparsed
2525
re.compile(r"\[(?P<txt>[^[]*)\]\((?P<uri>[^)]*)") #$ escapedCharacter=0:2 escapedCharacter=16:18 escapedCharacter=18:20
2626

2727
#Non-raw string

python/ql/test/library-tests/regex/test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@
6262
#Named group with caret and empty choice.
6363
re.compile(r'(?:(?P<n1>^(?:|x)))')
6464

65-
#Misparsed on LGTM
65+
#Misparsed
6666
re.compile(r"\[(?P<txt>[^[]*)\]\((?P<uri>[^)]*)")
6767

6868
re.compile("", re.M) # ODASA-8056

python/ql/test/library-tests/regexparser/unittests.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
# minimal example constructed by @erik-krogh
1212
baz = re.compile(r'\+0')
1313

14-
# exerpts from LGTM.com
14+
# exerpts from real-world results
1515
re.compile(r'\+0x')
1616
re.compile(r'\+0x.*')
1717
re.compile(r'+\-0+\.')

python/ql/test/query-tests/Classes/conflicting/odasa6643.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
#This code has conflicting attributes,
22
#but the documentation in the standard library tells you do it this way :(
33

4-
#See https://discuss.lgtm.com/t/warning-on-normal-use-of-python-socketserver-mixins/677
5-
64
class ThreadingMixIn(object):
75

86
def process_request(selfself, req):

python/ql/test/query-tests/Classes/missing-init/missing_init.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ class UVT(UT, PU):
3939
class IUVT(IUT, UVT):
4040
pass
4141

42-
#False positive observed on LGTM
42+
#False positive
4343
class M1(object):
4444
def __init__(self):
4545
print("A")

python/ql/test/query-tests/Expressions/eq/expressions_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ def __eq__(self, other):
7878
'''
7979
return self is other
8080

81-
#Was FP -- https://github.com/lgtmhq/lgtm-queries/issues/13
81+
#Was FP
8282
def both_sides_known(zero_based="auto", query_id=False):
8383
if query_id and zero_based == "auto":
8484
zero_based = True

python/ql/test/query-tests/Functions/general/explicit_return_in_init.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ def __init__(self):
4646

4747
# OK as procedure implicitly returns None
4848
#
49-
# this was seen in the wild: https://lgtm.com/projects/b/jjburton/cgmtools/snapshot/0d8a429b7ea17854a5e5341df98b1cbd54d7fe6c/files/mayaTools/cgm/lib/classes/AttrFactory.py?sort=name&dir=ASC&mode=heatmap#L90
49+
# this was seen in the wild:
5050
# using a pattern of `return procedure_that_logs_error()`
5151

5252
def procedure():

python/ql/test/query-tests/Functions/general/parameter_names.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ def meth(arg):
127127
# makes it such. As a consequence, the query `py/not-named-self` and other
128128
# relevant queries need to account for this.
129129
#
130-
# This has come up in the wild via LGTM as a false positive. For example,
130+
# This has come up in the wild as a false positive. For example,
131131
# `__init_subclass__`:
132132
# https://docs.python.org/3/reference/datamodel.html#customizing-class-creation
133133
# `__class_getitem__`:

0 commit comments

Comments
 (0)