Skip to content

Commit a3ff835

Browse files
authored
Merge pull request github#11300 from tamasvajk/kotlin-useless-param-2
Kotlin: Exclude .kt files from useless parameter query
2 parents b4b8649 + 48c37a2 commit a3ff835

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

java/ql/lib/semmle/code/java/deadcode/DeadCode.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ class DeadMethod extends Callable {
274274

275275
class RootdefCallable extends Callable {
276276
RootdefCallable() {
277-
this.fromSource() and
277+
this.getFile().isJavaSourceFile() and
278278
not this.(Method).overridesOrInstantiates(_)
279279
}
280280

java/ql/test/kotlin/query-tests/UselessParameter/Test.kt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,3 +19,6 @@ object O {}
1919
fun C.fn() {}
2020
fun C.Companion.fn() {}
2121
fun O.fn() {}
22+
23+
@Suppress("UNUSED_PARAMETER")
24+
fun fn2(a: Int) {}
Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +0,0 @@
1-
| Test.kt:11:8:11:18 | a | The parameter 'a' is never used. |
2-
| Test.kt:19:5:19:5 | <this> | The parameter '<this>' is never used. |

0 commit comments

Comments
 (0)