Update InsufficientControlFlowManagementWhenUsingBitOperations.ql

ihsinme · web-flow · commit a43698802f66 · 2021-04-12T17:36:50.000+03:00
diff --git a/cpp/ql/src/experimental/Security/CWE/CWE-691/InsufficientControlFlowManagementWhenUsingBitOperations.ql b/cpp/ql/src/experimental/Security/CWE/CWE-691/InsufficientControlFlowManagementWhenUsingBitOperations.ql
@@ -61,8 +61,7 @@ class DangerousBitOperations extends BinaryBitwiseOperation {
   /** Holds when the bit expression contains both arguments and a function call. */
   predicate dangerousArgumentChecking() {
     not this.getLeftOperand() instanceof Call and
-    globalValueNumber(this.getLeftOperand().getAChild*()) =
-      globalValueNumber(bfc.getAnArgument())
+    globalValueNumber(this.getLeftOperand().getAChild*()) = globalValueNumber(bfc.getAnArgument())
   }
 
   /** Holds when function calls are present in the bit expression. */

Original file line number	Diff line number	Diff line change
`@@ -61,8 +61,7 @@ class DangerousBitOperations extends BinaryBitwiseOperation {`
`61`	`61`	`/** Holds when the bit expression contains both arguments and a function call. */`
`62`	`62`	`predicate dangerousArgumentChecking() {`
`63`	`63`	`not this.getLeftOperand() instanceof Call and`
`64`		`- globalValueNumber(this.getLeftOperand().getAChild*()) =`
`65`		`- globalValueNumber(bfc.getAnArgument())`
	`64`	`+ globalValueNumber(this.getLeftOperand().getAChild*()) = globalValueNumber(bfc.getAnArgument())`
`66`	`65`	`}`
`67`	`66`
`68`	`67`	`/** Holds when function calls are present in the bit expression. */`