Skip to content

Commit a803120

Browse files
author
Max Schaefer
committed
Lower precision for a number of queries.
These queries are currently run by default, but don't have their results displayed. Looking through results on LGTM.com, they are either false positives (e.g., `BitwiseSignCheck` which flags many perfectly harmless operations and `CompareIdenticalValues` which mostly flags NaN checks) or harmless results that developers are unlikely to care about (e.g., `EmptyArrayInit` or `MisspelledIdentifier`). With this PR, the only queries that are still run but not displayed are security queries, where different considerations may apply.
1 parent 451ae7b commit a803120

21 files changed

+43
-20
lines changed

change-notes/1.25/analysis-javascript.md

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,29 @@
2323
| Expression has no effect (`js/useless-expression`) | Less results | This query no longer flags an expression when that expression is the only content of the containing file. |
2424
| Unknown directive (`js/unknown-directive`) | Less results | This query no longer flags directives generated by the Babel compiler. |
2525

26+
The following low-precision queries are no longer run by default on LGTM (their results already were not displayed):
27+
28+
- `js/angular/dead-event-listener`
29+
- `js/angular/unused-dependency`
30+
- `js/conflicting-html-attribute`
31+
- `js/useless-assignment-to-global`
32+
- `js/too-many-parameters`
33+
- `js/unused-property`
34+
- `js/bitwise-sign-check`
35+
- `js/comparison-of-identical-expressions`
36+
- `js/misspelled-identifier`
37+
- `js/jsdoc/malformed-param-tag`
38+
- `js/jsdoc/unknown-parameter`
39+
- `js/jsdoc/missing-parameter`
40+
- `js/omitted-array-element`
41+
- `js/ignored-setter-parameter`
42+
- `js/json-in-javascript-file`
43+
- `js/node/cyclic-import`
44+
- `js/node/unused-npm-dependency`
45+
- `js/single-run-loop`
46+
- `js/nested-loops-with-same-variable`
47+
- `js/return-outside-function`
48+
2649
## Changes to libraries
2750

2851
* Added data flow for `Map` and `Set`, and added matching type-tracking steps that can accessed using the `CollectionsTypeTracking` module.

javascript/ql/src/AngularJS/DeadAngularJSEventListener.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* @description An AngularJS event listener that listens for a non-existent event has no effect.
44
* @kind problem
55
* @problem.severity warning
6-
* @precision medium
6+
* @precision low
77
* @id js/angular/dead-event-listener
88
* @tags correctness
99
* frameworks/angularjs

javascript/ql/src/AngularJS/UnusedAngularDependency.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
* @description Unused dependencies are confusing, and should be removed.
44
* @kind problem
55
* @problem.severity recommendation
6-
* @precision high
6+
* @precision low
77
* @id js/angular/unused-dependency
88
* @tags maintainability
99
* frameworks/angularjs

javascript/ql/src/DOM/ConflictingAttributes.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
* @tags maintainability
99
* correctness
1010
* external/cwe/cwe-758
11-
* @precision medium
11+
* @precision low
1212
*/
1313

1414
import javascript

javascript/ql/src/Declarations/DeadStoreOfGlobal.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @tags maintainability
88
* correctness
99
* external/cwe/cwe-563
10-
* @precision medium
10+
* @precision low
1111
*/
1212

1313
import javascript

javascript/ql/src/Declarations/TooManyParameters.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
* @id js/too-many-parameters
77
* @tags testability
88
* readability
9-
* @precision high
9+
* @precision low
1010
*/
1111

1212
import javascript

javascript/ql/src/Declarations/UnusedProperty.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
* @problem.severity recommendation
66
* @id js/unused-property
77
* @tags maintainability
8-
* @precision high
8+
* @precision low
99
*/
1010

1111
import javascript

javascript/ql/src/Expressions/BitwiseSignCheck.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
* @id js/bitwise-sign-check
77
* @tags reliability
88
* correctness
9-
* @precision medium
9+
* @precision low
1010
*/
1111

1212
import javascript

javascript/ql/src/Expressions/CompareIdenticalValues.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
* convention
1212
* external/cwe/cwe-570
1313
* external/cwe/cwe-571
14-
* @precision medium
14+
* @precision low
1515
*/
1616

1717
import Clones

javascript/ql/src/Expressions/MisspelledIdentifier.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
* @id js/misspelled-identifier
77
* @tags maintainability
88
* readability
9-
* @precision high
9+
* @precision low
1010
*/
1111

1212
import Misspelling

0 commit comments

Comments
 (0)