Skip to content

Commit ab12b6c

Browse files
committed
Java: Convert android-web-resource-response to data extensions.
1 parent 5c15ad4 commit ab12b6c

File tree

3 files changed

+16
-11
lines changed

3 files changed

+16
-11
lines changed
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
extensions:
2+
- addsTo:
3+
pack: codeql/java-all
4+
extensible: extExperimentalSummaryModel
5+
data:
6+
- ["android.webkit", "WebResourceRequest", False, "getUrl", "", "", "Argument[-1]", "ReturnValue", "taint", "manual", "android-web-resource-response"]
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
extensions:
2+
- addsTo:
3+
pack: codeql/java-all
4+
extensible: extExperimentalSummaryModel
5+
data:
6+
- ["java.io", "FileInputStream", True, "FileInputStream", "", "", "Argument[0]", "Argument[-1]", "taint", "manual", "android-web-resource-response"]

java/ql/src/experimental/Security/CWE/CWE-200/AndroidWebResourceResponse.qll

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@ private import semmle.code.java.dataflow.ExternalFlow
66
private import semmle.code.java.dataflow.FlowSteps
77
private import semmle.code.java.frameworks.android.WebView
88

9+
private class ActivateModels extends ActiveExperimentalModels {
10+
ActivateModels() { this = "android-web-resource-response" }
11+
}
12+
913
/**
1014
* The Android class `android.webkit.WebResourceRequest` for handling web requests.
1115
*/
@@ -68,14 +72,3 @@ private class FetchUrlStep extends AdditionalValueStep {
6872
)
6973
}
7074
}
71-
72-
/** Value/taint steps relating to url loading and file reading in an Android application. */
73-
private class LoadUrlSummaries extends SummaryModelCsv {
74-
override predicate row(string row) {
75-
row =
76-
[
77-
"java.io;FileInputStream;true;FileInputStream;;;Argument[0];Argument[-1];taint;manual",
78-
"android.webkit;WebResourceRequest;false;getUrl;;;Argument[-1];ReturnValue;taint;manual"
79-
]
80-
}
81-
}

0 commit comments

Comments
 (0)