Skip to content

Commit ac0c42c

Browse files
atorralbaerik-krogh
andcommitted
Apply suggestions from code review
Co-authored-by: Erik Krogh Kristensen <[email protected]>
1 parent 227e099 commit ac0c42c

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

ql/ql/src/queries/style/OmittableExists.ql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ where
1515
existsArgument = any(Exists e).getAnArgument() and
1616
use = unique( | | existsArgument.getAnAccess()) and
1717
exists(Call c, int argPos | c.getArgument(argPos) = use |
18-
not existsArgument.getType().getASuperType+() = c.getTarget().getParameterType(argPos)
18+
existsArgument.getType() = c.getTarget().getParameterType(argPos).getASuperType*()
1919
)
20-
select existsArgument, "This exists argument can be omitted by using a don't-care expression $@.",
20+
select existsArgument, "This exists variable can be omitted by using a don't-care expression $@.",
2121
use, "in this argument"
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
| Test.qll:10:10:10:14 | i | This exists argument can be omitted by using a don't-care expression $@. | Test.qll:10:29:10:29 | i | in this argument |
1+
| Test.qll:10:10:10:14 | i | This exists variable can be omitted by using a don't-care expression $@. | Test.qll:10:29:10:29 | i | in this argument |

0 commit comments

Comments
 (0)