Skip to content

Commit ae00518

Browse files
committed
remove the isAdditionalTaintStep predicate from UnsafeHtmlConstructionQuery, as it was not needed
1 parent 7c6ee5f commit ae00518

File tree

1 file changed

+0
-16
lines changed

1 file changed

+0
-16
lines changed

ruby/ql/lib/codeql/ruby/security/UnsafeHtmlConstructionQuery.qll

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -30,20 +30,4 @@ class Configuration extends TaintTracking::Configuration {
3030
override DataFlow::FlowFeature getAFeature() {
3131
result instanceof DataFlow::FeatureHasSourceCallContext
3232
}
33-
34-
override predicate isAdditionalTaintStep(DataFlow::Node pred, DataFlow::Node succ) {
35-
// if an array element gets tainted, then we treat the entire array as tainted
36-
exists(DataFlow::CallNode call |
37-
call.getMethodName() = ["<<", "push", "append"] and
38-
call.getReceiver() = succ and
39-
pred = call.getArgument(0) and
40-
call.getNumberOfArguments() = 1
41-
)
42-
or
43-
exists(DataFlow::CallNode call |
44-
call.getMethodName() = "[]" and
45-
succ = call and
46-
pred = call.getArgument(_)
47-
)
48-
}
4933
}

0 commit comments

Comments
 (0)