Skip to content

Commit aff0e0e

Browse files
committed
Cleanup according to review comments.
1 parent 31a2972 commit aff0e0e

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

java/ql/src/experimental/Security/CWE/CWE-917/OgnlInjection.qhelp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ and validate the expressions before evaluation.</p>
2727
</example>
2828

2929
<references>
30-
<li>OGNL library: <a href="https://github.com/jkuhnert/ognl/">OGNL library</a>.</li>
30+
<li><a href="https://github.com/jkuhnert/ognl/">OGNL library</a>.</li>
3131
<li>Struts security: <a href="https://struts.apache.org/security/#proactively-protect-from-ognl-expression-injections-attacks-if-easily-applicable">Proactively protect from OGNL Expression Injections attacks</a>.</li>
3232
</references>
3333
</qhelp>

java/ql/src/experimental/Security/CWE/CWE-917/OgnlInjectionLib.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ class TypeOgnlUtil extends Class {
4949
*/
5050
predicate ognlSinkMethod(Method m, int index) {
5151
(
52-
m.getDeclaringType() instanceof TypeOgnl and index = 0
52+
m.getDeclaringType() instanceof TypeOgnl
5353
or
5454
m.getDeclaringType().getAnAncestor*() instanceof TypeNode
5555
) and

0 commit comments

Comments
 (0)