Remove redundant check

edvraa · edvraa · commit b027fddc7ed5 · 2021-04-15T00:14:09.000+03:00
diff --git a/csharp/ql/src/Security Features/CWE-502/UnsafeDeserialization.ql b/csharp/ql/src/Security Features/CWE-502/UnsafeDeserialization.ql
@@ -25,8 +25,7 @@ where
       safeTypeUsage.getNode().asExpr().getParent() = deserializeCall
     )
     or
-    sink instanceof ConstructorOrStaticMethodSink and
-    deserializeCall.getAnArgument() = sink.asExpr()
+    sink instanceof ConstructorOrStaticMethodSink
   )
 select deserializeCall,
   "Unsafe deserializer is used. Make sure the value being deserialized comes from a trusted source."

Original file line number	Diff line number	Diff line change
`@@ -25,8 +25,7 @@ where`
`25`	`25`	`safeTypeUsage.getNode().asExpr().getParent() = deserializeCall`
`26`	`26`	`)`
`27`	`27`	`or`
`28`		`- sink instanceof ConstructorOrStaticMethodSink and`
`29`		`- deserializeCall.getAnArgument() = sink.asExpr()`
	`28`	`+ sink instanceof ConstructorOrStaticMethodSink`
`30`	`29`	`)`
`31`	`30`	`select deserializeCall,`
`32`	`31`	`"Unsafe deserializer is used. Make sure the value being deserialized comes from a trusted source."`