Skip to content

Commit b039267

Browse files
erik-kroghasgerf
andauthored
Apply suggestions from code review
Co-authored-by: Asger F <[email protected]>
1 parent c95a8e6 commit b039267

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
lgtm,codescanning
2-
* The `js/template-object-injection` query has been added. It highlights servers where an templating engine may allow attacks on the server.
2+
* The `js/template-object-injection` query has been added. It highlights places where an attacker can pass special parameters to a template engine.

javascript/ql/src/Security/CWE-073/TemplateObjectInjection.qhelp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,14 @@ local file reads or even remote code execution.
1111

1212
<recommendation>
1313
<p>
14-
Avoid using user-controlled objects as arguments to template engine, instead construct the object explicitly with
14+
Avoid using user-controlled objects as arguments to a template engine. Instead, construct the object explicitly with
1515
the specific properties needed by the template.
1616
</p>
1717
</recommendation>
1818

1919
<example>
2020
<p>
21-
In the below example a server uses the user-controlled <code>profile</code> object to
21+
In the example below a server uses the user-controlled <code>profile</code> object to
2222
render the <code>index</code> template.
2323
</p>
2424
<sample src="examples/TemplateObjectInjection.js" />
@@ -42,4 +42,4 @@ cwe.mitre.org: <a href="https://cwe.mitre.org/data/definitions/73.html">CWE-73:
4242
</li>
4343

4444
</references>
45-
</qhelp>
45+
</qhelp>

0 commit comments

Comments
 (0)