Skip to content

Commit b06cd6d

Browse files
committed
JS: Update Node.isIncomplete
1 parent 5568f0e commit b06cd6d

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

javascript/ql/src/semmle/javascript/DefUse.qll

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,6 @@ private predicate defn(ControlFlowNode def, Expr lhs, AST::ValueNode rhs) {
4545
exists(EnumMember member | def = member.getIdentifier() |
4646
lhs = def and rhs = member.getInitializer()
4747
)
48-
or
49-
lhs = def and def.(Parameter).getDefault() = rhs
5048
}
5149

5250
/**

javascript/ql/src/semmle/javascript/dataflow/DataFlow.qll

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1527,6 +1527,9 @@ module DataFlow {
15271527
e instanceof FunctionBindExpr
15281528
or
15291529
e instanceof TaggedTemplateExpr
1530+
or
1531+
e instanceof Parameter and
1532+
not localArgumentPassing(_, e)
15301533
)
15311534
or
15321535
nd.asExpr() instanceof ExternalModuleReference and
@@ -1562,10 +1565,6 @@ module DataFlow {
15621565
* Holds if definition `def` cannot be completely analyzed due to `cause`.
15631566
*/
15641567
private predicate defIsIncomplete(VarDef def, Incompleteness cause) {
1565-
def instanceof Parameter and
1566-
not localArgumentPassing(_, def) and
1567-
cause = "call"
1568-
or
15691568
def instanceof ImportSpecifier and
15701569
cause = "import"
15711570
or

0 commit comments

Comments
 (0)