Skip to content

Commit b23fabe

Browse files
committed
Fix errors from previous PR
1 parent 1c2476c commit b23fabe

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

java/ql/src/semmle/code/java/frameworks/apache/Collections.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ private import semmle.code.java.dataflow.FlowSteps
55
private import semmle.code.java.dataflow.ExternalFlow
66

77
/**
8-
* The method `isNotEmpty` in either `org.apache.commons.collections.CollectionUtils`
8+
* The method `isEmpty` in either `org.apache.commons.collections.CollectionUtils`
99
* or `org.apache.commons.collections4.CollectionUtils`.
1010
*/
1111
class MethodApacheCollectionsIsEmpty extends Method {
@@ -146,7 +146,7 @@ private class ApacheKeyValueModel extends SummaryModelCsv {
146146
[
147147
".keyvalue;AbstractKeyValue;true;AbstractKeyValue;;;Argument[0];MapKey of Argument[-1];value",
148148
".keyvalue;AbstractKeyValue;true;AbstractKeyValue;;;Argument[1];MapValue of Argument[-1];value",
149-
".keyvalue;AbstractKeyValue;true;setKey;;;MapValue of Argument[-1];ReturnValue;value",
149+
".keyvalue;AbstractKeyValue;true;setKey;;;MapKey of Argument[-1];ReturnValue;value",
150150
".keyvalue;AbstractKeyValue;true;setKey;;;Argument[0];MapKey of Argument[-1];value",
151151
".keyvalue;AbstractKeyValue;true;setValue;;;MapValue of Argument[-1];ReturnValue;value",
152152
".keyvalue;AbstractKeyValue;true;setValue;;;Argument[0];MapValue of Argument[-1];value",

java/ql/test/library-tests/frameworks/apache-collections/Test.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -225,16 +225,16 @@ public void test() {
225225
sink(getMapKey(out)); // $ hasValueFlow
226226
}
227227
{
228-
// "org.apache.commons.collections4.keyvalue;AbstractKeyValue;true;setKey;;;MapValue of Argument[-1];ReturnValue;value"
228+
// "org.apache.commons.collections4.keyvalue;AbstractKeyValue;true;setKey;;;MapKey of Argument[-1];ReturnValue;value"
229229
Object out = null;
230-
DefaultKeyValue in = newDKVWithMapValue((String)source());
230+
DefaultKeyValue in = newDKVWithMapKey((String)source());
231231
out = in.setKey(null);
232232
sink(out); // $ hasValueFlow
233233
}
234234
{
235-
// "org.apache.commons.collections4.keyvalue;AbstractKeyValue;true;setKey;;;MapValue of Argument[-1];ReturnValue;value"
235+
// "org.apache.commons.collections4.keyvalue;AbstractKeyValue;true;setKey;;;MapKey of Argument[-1];ReturnValue;value"
236236
Object out = null;
237-
MyAbstractKeyValue in = newMAKVWithMapValue((String)source());
237+
MyAbstractKeyValue in = newMAKVWithMapKey((String)source());
238238
out = in.mySetKey(null);
239239
sink(out); // $ hasValueFlow
240240
}

0 commit comments

Comments
 (0)