Skip to content

Commit b2b009c

Browse files
committed
qldoc adjustment
1 parent 1be326a commit b2b009c

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

javascript/ql/src/semmle/javascript/Collections.qll

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ private import DataFlow::PseudoProperties
1515
* `load`/`store`/`loadStore` can be used in the `CollectionsTypeTracking` module.
1616
* (Thereby avoiding naming conflicts with a "cousin" `AdditionalFlowStep` implementation.)
1717
*/
18-
private abstract class CollectionFlowStep extends DataFlow::AdditionalFlowStep {
18+
abstract private class CollectionFlowStep extends DataFlow::AdditionalFlowStep {
1919
final override predicate step(DataFlow::Node pred, DataFlow::Node succ) { none() }
2020

2121
final override predicate step(
@@ -82,7 +82,10 @@ module CollectionsTypeTracking {
8282
exists(CollectionFlowStep step, string field |
8383
summary = LoadStep(field) and
8484
step.load(pred, result, field) and
85-
(not step.canLoadValueWithKnownKey() or not field = mapValueUnknownKey()) // for a step that could load a known key, we prune the steps where the key is unknown.
85+
not (
86+
step.canLoadValueWithKnownKey() and // for a step that could load a known key,
87+
field = mapValueUnknownKey() // don't load values with an unknown key.
88+
)
8689
or
8790
summary = StoreStep(field) and
8891
step.store(pred, result, field)

0 commit comments

Comments
 (0)