Skip to content

Commit b3feb4f

Browse files
hvitvedasgerf
andauthored
Update ruby/ql/lib/codeql/ruby/typetracking/TypeTrackerSpecific.qll
Co-authored-by: Asger F <[email protected]>
1 parent c04b90b commit b3feb4f

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

ruby/ql/lib/codeql/ruby/typetracking/TypeTrackerSpecific.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -233,8 +233,8 @@ predicate returnStep(Node nodeFrom, Node nodeTo) {
233233
exists(ExprNodes::CallCfgNode call |
234234
nodeFrom instanceof DataFlowPrivate::ReturnNode and
235235
nodeFrom.(DataFlowPrivate::NodeImpl).getCfgScope() = DataFlowDispatch::getTarget(call) and
236-
// deliberately do not include `getInitializeTarget`, since there is no direct
237-
// flow out (only side-effects on `self`). Any fields being set in the initializer
236+
// deliberately do not include `getInitializeTarget`, since calls to `new` should not
237+
// get the return value from `initialize`. Any fields being set in the initializer
238238
// will reach all reads via `callStep` and `localFieldStep`.
239239
nodeTo.asExpr().getNode() = call.getNode()
240240
)

0 commit comments

Comments
 (0)