Skip to content

Commit b46b495

Browse files
Raz0rasgerf
andcommitted
Apply suggestions from code review
`interpretsValueAsJavaScript` -> `interpretsValueAsJavaScriptUrl` Co-authored-by: Asger F <[email protected]>
1 parent 54db6c4 commit b46b495

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

javascript/ql/src/semmle/javascript/security/dataflow/ClientSideUrlRedirectCustomizations.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ module ClientSideUrlRedirect {
153153
class AttributeWriteUrlSink extends ScriptUrlSink, DataFlow::ValueNode {
154154
AttributeWriteUrlSink() {
155155
exists(DomPropWriteNode pw |
156-
pw.interpretsValueAsJavaScript() and
156+
pw.interpretsValueAsJavaScriptUrl() and
157157
this = DataFlow::valueNode(pw.getRhs())
158158
)
159159
}

javascript/ql/src/semmle/javascript/security/dataflow/DOM.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ class DomPropWriteNode extends Assignment {
121121
/**
122122
* Holds if the assigned value is interpreted as JavaScript via javascript: protocol.
123123
*/
124-
predicate interpretsValueAsJavaScript() {
124+
predicate interpretsValueAsJavaScriptUrl() {
125125
lhs.getPropertyName() = "action" or
126126
lhs.getPropertyName() = "formaction" or
127127
lhs.getPropertyName() = "href" or

0 commit comments

Comments
 (0)