Merge pull request github#2977 from BekaValentine/python-objectapi-to-valueapi-catchingbaseexception

tausbn · web-flow · commit b51e2a9e80c2 · 2020-03-09T22:54:50.000+01:00
Python: ObjectAPI to ValueAPI: CatchingBaseException
diff --git a/python/ql/src/Exceptions/CatchingBaseException.ql b/python/ql/src/Exceptions/CatchingBaseException.ql
@@ -19,7 +19,7 @@ predicate doesnt_reraise(ExceptStmt ex) {
 }
 
 predicate catches_base_exception(ExceptStmt ex) {
-     ex.getType().refersTo(theBaseExceptionType())
+     ex.getType().pointsTo(ClassValue::baseException())
      or
      not exists(ex.getType())
 }

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ predicate doesnt_reraise(ExceptStmt ex) {`
`19`	`19`	`}`
`20`	`20`
`21`	`21`	`predicate catches_base_exception(ExceptStmt ex) {`
`22`		`- ex.getType().refersTo(theBaseExceptionType())`
	`22`	`+ ex.getType().pointsTo(ClassValue::baseException())`
`23`	`23`	`or`
`24`	`24`	`not exists(ex.getType())`
`25`	`25`	`}`