Skip to content

Commit b5c9240

Browse files
authored
Merge pull request github#14845 from github/max-schaefer/minor
Automodel: Fix a few nits.
2 parents 620e8dc + 1bed9f9 commit b5c9240

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

java/ql/automodel/src/AutomodelEndpointTypes.qll

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,8 @@ abstract class EndpointType extends string {
1818
* Gets the name of the sink/source kind for this endpoint type as used in models-as-data.
1919
*
2020
* See https://github.com/github/codeql/blob/44213f0144fdd54bb679ca48d68b28dcf820f7a8/java/ql/lib/semmle/code/java/dataflow/ExternalFlow.qll#LL353C11-L357C31
21+
* for sink types, and https://github.com/github/codeql/blob/44213f0144fdd54bb679ca48d68b28dcf820f7a8/java/ql/lib/semmle/code/java/dataflow/ExternalFlow.qll#L365
22+
* for source types.
2123
*/
2224
final string getKind() { result = this }
2325
}

java/ql/automodel/src/AutomodelSharedCharacteristics.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,12 +63,12 @@ signature module CandidateSig {
6363
predicate isSink(Endpoint e, string kind, string provenance);
6464

6565
/**
66-
* Holds if `e` is a sink with the label `kind`, and provenance `provenance`.
66+
* Holds if `e` is a source with the label `kind`, and provenance `provenance`.
6767
*/
6868
predicate isSource(Endpoint e, string kind, string provenance);
6969

7070
/**
71-
* Holds if `e` is not a sink of any kind.
71+
* Holds if `e` is not a source or sink of any kind.
7272
*/
7373
predicate isNeutral(Endpoint e);
7474

0 commit comments

Comments
 (0)