Remove "private" marker from configurations

egregius313 · egregius313 · commit b64ca5dcaab9 · 2023-03-20T12:26:54.000-04:00
diff --git a/java/ql/src/Security/CWE/CWE-078/ExecTaintedLocal.ql b/java/ql/src/Security/CWE/CWE-078/ExecTaintedLocal.ql
@@ -17,7 +17,7 @@ import semmle.code.java.dataflow.FlowSources
 import semmle.code.java.security.ExternalProcess
 import semmle.code.java.security.CommandArguments
 
-private module LocalUserInputToArgumentToExecFlowConfig implements DataFlow::ConfigSig {
+module LocalUserInputToArgumentToExecFlowConfig implements DataFlow::ConfigSig {
   predicate isSource(DataFlow::Node src) { src instanceof LocalUserInput }
 
   predicate isSink(DataFlow::Node sink) { sink.asExpr() instanceof ArgumentToExec }
diff --git a/java/ql/src/Security/CWE/CWE-079/XSSLocal.ql b/java/ql/src/Security/CWE/CWE-079/XSSLocal.ql
@@ -15,7 +15,7 @@ import java
 import semmle.code.java.dataflow.FlowSources
 import semmle.code.java.security.XSS
 
-private module XssLocalConfig implements DataFlow::ConfigSig {
+module XssLocalConfig implements DataFlow::ConfigSig {
   predicate isSource(DataFlow::Node source) { source instanceof LocalUserInput }
 
   predicate isSink(DataFlow::Node sink) { sink instanceof XssSink }
diff --git a/java/ql/src/Security/CWE/CWE-089/SqlConcatenated.ql b/java/ql/src/Security/CWE/CWE-089/SqlConcatenated.ql
@@ -25,7 +25,7 @@ class UncontrolledStringBuilderSource extends DataFlow::ExprNode {
   }
 }
 
-private module UncontrolledStringBuilderSourceFlowConfig implements DataFlow::ConfigSig {
+module UncontrolledStringBuilderSourceFlowConfig implements DataFlow::ConfigSig {
   predicate isSource(DataFlow::Node src) { src instanceof UncontrolledStringBuilderSource }
 
   predicate isSink(DataFlow::Node sink) { sink instanceof QueryInjectionSink }
diff --git a/java/ql/src/Security/CWE/CWE-089/SqlTaintedLocal.ql b/java/ql/src/Security/CWE/CWE-089/SqlTaintedLocal.ql
@@ -16,7 +16,7 @@ import semmle.code.java.Expr
 import semmle.code.java.dataflow.FlowSources
 import semmle.code.java.security.SqlInjectionQuery
 
-private module LocalUserInputToQueryInjectionFlowConfig implements DataFlow::ConfigSig {
+module LocalUserInputToQueryInjectionFlowConfig implements DataFlow::ConfigSig {
   predicate isSource(DataFlow::Node src) { src instanceof LocalUserInput }
 
   predicate isSink(DataFlow::Node sink) { sink instanceof QueryInjectionSink }
diff --git a/java/ql/src/Security/CWE/CWE-129/ImproperValidationOfArrayConstructionCodeSpecified.ql b/java/ql/src/Security/CWE/CWE-129/ImproperValidationOfArrayConstructionCodeSpecified.ql
@@ -15,7 +15,7 @@ import java
 import ArraySizing
 import semmle.code.java.dataflow.TaintTracking
 
-private module BoundedFlowSourceConfig implements DataFlow::ConfigSig {
+module BoundedFlowSourceConfig implements DataFlow::ConfigSig {
   predicate isSource(DataFlow::Node source) {
     source instanceof BoundedFlowSource and
     // There is not a fixed lower bound which is greater than zero.
diff --git a/java/ql/src/Security/CWE/CWE-129/ImproperValidationOfArrayConstructionLocal.ql b/java/ql/src/Security/CWE/CWE-129/ImproperValidationOfArrayConstructionLocal.ql
@@ -15,7 +15,7 @@ import java
 import ArraySizing
 import semmle.code.java.dataflow.FlowSources
 
-private module ImproperValidationOfArrayConstructionLocalConfig implements DataFlow::ConfigSig {
+module ImproperValidationOfArrayConstructionLocalConfig implements DataFlow::ConfigSig {
   predicate isSource(DataFlow::Node source) { source instanceof LocalUserInput }
 
   predicate isSink(DataFlow::Node sink) {
diff --git a/java/ql/src/Security/CWE/CWE-129/ImproperValidationOfArrayIndex.ql b/java/ql/src/Security/CWE/CWE-129/ImproperValidationOfArrayIndex.ql
@@ -14,7 +14,7 @@ import java
 import ArraySizing
 import semmle.code.java.dataflow.FlowSources
 
-private module ImproperValidationOfArrayIndexConfig implements DataFlow::ConfigSig {
+module ImproperValidationOfArrayIndexConfig implements DataFlow::ConfigSig {
   predicate isSource(DataFlow::Node source) { source instanceof RemoteFlowSource }
 
   predicate isSink(DataFlow::Node sink) {
diff --git a/java/ql/src/Security/CWE/CWE-129/ImproperValidationOfArrayIndexCodeSpecified.ql b/java/ql/src/Security/CWE/CWE-129/ImproperValidationOfArrayIndexCodeSpecified.ql
@@ -16,7 +16,7 @@ import ArraySizing
 import BoundingChecks
 import semmle.code.java.dataflow.TaintTracking
 
-private module BoundedFlowSourceConfig implements DataFlow::ConfigSig {
+module BoundedFlowSourceConfig implements DataFlow::ConfigSig {
   predicate isSource(DataFlow::Node source) { source instanceof BoundedFlowSource }
 
   predicate isSink(DataFlow::Node sink) {
diff --git a/java/ql/src/Security/CWE/CWE-129/ImproperValidationOfArrayIndexLocal.ql b/java/ql/src/Security/CWE/CWE-129/ImproperValidationOfArrayIndexLocal.ql
@@ -15,7 +15,7 @@ import java
 import ArraySizing
 import semmle.code.java.dataflow.FlowSources
 
-private module ImproperValidationOfArrayIndexLocalConfig implements DataFlow::ConfigSig {
+module ImproperValidationOfArrayIndexLocalConfig implements DataFlow::ConfigSig {
   predicate isSource(DataFlow::Node source) { source instanceof LocalUserInput }
 
   predicate isSink(DataFlow::Node sink) {
diff --git a/java/ql/src/Security/CWE/CWE-190/ArithmeticWithExtremeValues.ql b/java/ql/src/Security/CWE/CWE-190/ArithmeticWithExtremeValues.ql
@@ -33,7 +33,7 @@ class ExtremeSource extends VarAccess {
   ExtremeSource() { this.getVariable() instanceof ExtremeValueField }
 }
 
-private module MaxValueFlowConfig implements DataFlow::ConfigSig {
+module MaxValueFlowConfig implements DataFlow::ConfigSig {
   predicate isSource(DataFlow::Node source) {
     source.asExpr().(ExtremeSource).getVariable() instanceof MaxValueField
   }
@@ -47,7 +47,7 @@ private module MaxValueFlowConfig implements DataFlow::ConfigSig {
 
 module MaxValueFlow = DataFlow::Make<MaxValueFlowConfig>;
 
-private module MinValueFlowConfig implements DataFlow::ConfigSig {
+module MinValueFlowConfig implements DataFlow::ConfigSig {
   predicate isSource(DataFlow::Node source) {
     source.asExpr().(ExtremeSource).getVariable() instanceof MinValueField
   }
diff --git a/java/ql/src/Security/CWE/CWE-209/StackTraceExposure.ql b/java/ql/src/Security/CWE/CWE-209/StackTraceExposure.ql
@@ -120,7 +120,7 @@ class GetMessageFlowSource extends MethodAccess {
   }
 }
 
-private module GetMessageFlowSourceToHttpResponseSinkFlowConfig implements DataFlow::ConfigSig {
+module GetMessageFlowSourceToHttpResponseSinkFlowConfig implements DataFlow::ConfigSig {
   predicate isSource(DataFlow::Node src) { src.asExpr() instanceof GetMessageFlowSource }
 
   predicate isSink(DataFlow::Node sink) { sink instanceof InformationLeakSink }
diff --git a/java/ql/src/Security/CWE/CWE-614/InsecureCookie.ql b/java/ql/src/Security/CWE/CWE-614/InsecureCookie.ql
@@ -26,7 +26,7 @@ predicate isSafeSecureCookieSetting(Expr e) {
   )
 }
 
-private module SecureCookieConfig implements DataFlow::ConfigSig {
+module SecureCookieConfig implements DataFlow::ConfigSig {
   predicate isSource(DataFlow::Node source) {
     exists(MethodAccess ma, Method m | ma.getMethod() = m |
       m.getDeclaringType() instanceof TypeCookie and

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ class UncontrolledStringBuilderSource extends DataFlow::ExprNode {`
`25`	`25`	`}`
`26`	`26`	`}`
`27`	`27`
`28`		`-private module UncontrolledStringBuilderSourceFlowConfig implements DataFlow::ConfigSig {`
	`28`	`+module UncontrolledStringBuilderSourceFlowConfig implements DataFlow::ConfigSig {`
`29`	`29`	`predicate isSource(DataFlow::Node src) { src instanceof UncontrolledStringBuilderSource }`
`30`	`30`
`31`	`31`	`predicate isSink(DataFlow::Node sink) { sink instanceof QueryInjectionSink }`
Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ class ExtremeSource extends VarAccess {`
`33`	`33`	`ExtremeSource() { this.getVariable() instanceof ExtremeValueField }`
`34`	`34`	`}`
`35`	`35`
`36`		`-private module MaxValueFlowConfig implements DataFlow::ConfigSig {`
	`36`	`+module MaxValueFlowConfig implements DataFlow::ConfigSig {`
`37`	`37`	`predicate isSource(DataFlow::Node source) {`
`38`	`38`	`source.asExpr().(ExtremeSource).getVariable() instanceof MaxValueField`
`39`	`39`	`}`
`@@ -47,7 +47,7 @@ private module MaxValueFlowConfig implements DataFlow::ConfigSig {`
`47`	`47`
`48`	`48`	`module MaxValueFlow = DataFlow::Make<MaxValueFlowConfig>;`
`49`	`49`
`50`		`-private module MinValueFlowConfig implements DataFlow::ConfigSig {`
	`50`	`+module MinValueFlowConfig implements DataFlow::ConfigSig {`
`51`	`51`	`predicate isSource(DataFlow::Node source) {`
`52`	`52`	`source.asExpr().(ExtremeSource).getVariable() instanceof MinValueField`
`53`	`53`	`}`